Fix IllegalArgumentException in DamageIndicatedItemFluidContainer.canDrain on empty container#219
Merged
rubensworks merged 2 commits intomaster-1.21from Mar 6, 2026
Conversation
…idContainer Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue in DamageIndicatedItemFluidContainer
Fix IllegalArgumentException in DamageIndicatedItemFluidContainer.canDrain on empty container
Mar 6, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeoForge 21.11.38-beta+ throws
IllegalArgumentExceptionwhenextractis called with an emptyFluidResource.canDrainwas unconditionally passingfluidHandler.getResource(0)toextract, which is an empty resource when the container holds no fluid.Change
canDrain, extract the resource before opening the transaction and short-circuit withfalseifresource.isEmpty()— mirroring the fix applied downstream in EvilCraft'sItemBloodContainer, but at the base class level so all subclasses benefit.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.puppycrawl.com/opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-2e0d869fa8235758/dbs/java/working/files-to-index7661378451342775573.list --sourceArchiveDir=/tmp/codeql-scratch-2e0d869fa8235758/dbs/java/src --outputDir=/tmp/codeql-scratch-2e0d869fa8235758/dbs/java/trap/java(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.